Fix a bunch of minor save-analysis bugs #45709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 2, 2017 08:12
This special cases the function type sugar in paths and deals with traits bounds as just the path parts. That required refactoring the path collector to distinguish between variable decls and references in patterns, basically just to please the borrow checker. cc rust-dev-tools/rls-analysis#37
|
@bors r+ |
|
📌 Commit 5d3be12 has been approved by |
kennytm
added
the
S-waiting-on-bors
|
⌛ Testing commit 5d3be12 with merge 0030cab94cd7ab2ccf696eda3b37720c50d157dd... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
⌛ Testing commit 5d3be12 with merge 8861eccb08cfe49231d436bd174c1ab433a249fe... |
|
💔 Test failed - status-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Nov 4, 2017
Fix a bunch of minor save-analysis bugs r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
nrc
pushed a commit
to nrc/rust
that referenced
this pull request
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb